Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ckeditor5-dev-* utils compatible with webpack 5 #10735

Closed
pomek opened this issue Oct 21, 2021 · 2 comments
Closed

Make ckeditor5-dev-* utils compatible with webpack 5 #10735

pomek opened this issue Oct 21, 2021 · 2 comments
Labels
package:dev resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Oct 21, 2021

Provide a description of the task

As the migration of the entire CKEditor 5 environment is a much more complex task than we expected, and it may span a few iterations, let's update our dev utils to produce a proper build using both webpack versions: 4 and 5.

Scope (based on ckeditor/ckeditor5-dev#729):

  • [utils] styles.getPostCssConfig() - the PostCSS configuration,
  • [utils] Move webpack from dependencies to peerDependencies as the builds.getDllPluginWebpackConfig() function should provide a configuration without forcing using a specified version of webpack.

Related issues:

@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. package:dev labels Oct 21, 2021
@pomek pomek self-assigned this Oct 21, 2021
@pomek pomek added this to the iteration 48 milestone Oct 21, 2021
@pomek
Copy link
Member Author

pomek commented Oct 21, 2021

Move webpack from dependencies to peerDependencies as the builds.getDllPluginWebpackConfig() ...

In fact, webpack is not specified as dep/devDep: https://github.com/ckeditor/ckeditor5-dev/blob/c0ecd4fe678b797167da094a2b09700cf82be64f/packages/ckeditor5-dev-utils/package.json#L7-L36

@pomek
Copy link
Member Author

pomek commented Oct 21, 2021

I just figured out that we don't need any changes in dev-utils. Webpack 5 works fine. So, the issue is not valid.

@pomek pomek closed this as completed Oct 21, 2021
@pomek pomek added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Oct 21, 2021
@pomek pomek removed their assignment Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

1 participant