Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The comment icon could blend in better with the rest of the project #10594

Closed
oleq opened this issue Sep 23, 2021 · 1 comment
Closed

The comment icon could blend in better with the rest of the project #10594

oleq opened this issue Sep 23, 2021 · 1 comment
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Sep 23, 2021

📝 Provide a description of the improvement

I noticed the comment icon stands out (especially in its toolbar form):

  • It has a fill, unlike most of CKEditor 5 icons.
  • It uses an oval instead of a boxy shape.

Here's the entire CKE5 iconset

I figured this could be improved quite easily and I created a couple of mockups with different icon styles:

v1

v2

v3


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. package:theme-lark domain:ui/ux This issue reports a problem related to UI or UX. labels Sep 23, 2021
@Reinmar
Copy link
Member

Reinmar commented Sep 24, 2021

I'd say v1. It aligns the style of the icon to our theme, without changing its content. Hence, it's a safe change that does not require deep analysis.

@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Sep 24, 2021
@oleq oleq self-assigned this Oct 8, 2021
@oleq oleq added this to the iteration 48 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants