Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List element (ul) disappears in the slot reconversion guide #10314

Closed
niegowski opened this issue Aug 5, 2021 · 1 comment
Closed

List element (ul) disappears in the slot reconversion guide #10314

niegowski opened this issue Aug 5, 2021 · 1 comment
Labels
package:engine resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@niegowski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. https://ckeditor.com/docs/ckeditor5/latest/framework/guides/deep-dive/conversion/element-reconversion.html
  2. make a list inside some of the card section
  3. click the "change type" button

✔️ Expected result

The <ul> is still there.

❌ Actual result

The <ul> is no longer in the view, only <li> with its content remains.

❓ Possible solution

This is happening because of reusing the old view elements that were mapped to the model element (and ul elements are not mapped - only lis are).

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. package:engine squad:compat labels Aug 5, 2021
@niegowski niegowski mentioned this issue Aug 5, 2021
Closed
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:compat labels Sep 27, 2021
@Reinmar
Copy link
Member

Reinmar commented Feb 2, 2022

It will be fixed by #10568.

@Reinmar Reinmar closed this as completed Feb 2, 2022
@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reinmar @niegowski