Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content minimap MVP2 #10089

Open
oleq opened this issue Jul 6, 2021 · 10 comments
Open

Content minimap MVP2 #10089

oleq opened this issue Jul 6, 2021 · 10 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Jul 6, 2021

📝 Provide a description of the improvement

Note: Demo of the feature is available in the documentation.

This issue is a follow-up of #10079 mainly to collect ideas, comments, bugs, and feature requests.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Jul 6, 2021
@oleq
Copy link
Member Author

oleq commented Jul 6, 2021

Things missing after MVP1 (+bugs):

  • Tests
  • Code coverage
  • Support for multi-root
  • Dynamic root width support
  • Integration with frameworks (React, Angular, etc.)
  • Performance optimization
  • Manual test descriptions
  • Moving RectDrawer somewhere else so it can be shared
  • Moving cloneEditingViewDomRoot() somewhere else so it can be shared
  • Some way to display the selection (as a marker?)
  • Glitching when dragging on Safari in full page (in-body) mode with some long content.
  • Integration with focus tracker (clicking the minimap should not blur the editor).
  • Because of the scale() in CSS, the content width is wrong unless set declaratively in px for .ck-content (text wraps like scale is 1, then it is downscaled). Possible solution: get computed style width from .ck-content and pass it to the minimap.

@wimleers
Copy link

Holy crap 🤩 This is EPIC!

Ideally this would be enabled in lieu of increasing the height of the CKE5 instance as soon as the length hits a certain threshold… but that doesn’t seem configurable yet according to https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/api/module_minimap_minimap-MinimapConfig.html.

If I go to https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/features/general-html-support.html and delete all content in the demo and type a single phrase, the mini map just looks really weird — which is why I'm suggesting to only make it appear once a threshold is hit:

Screenshot 2021-07-28 at 11 38 34

P.S.: long time no see, @oleq! 😊 👋

@oleq
Copy link
Member Author

oleq commented Aug 2, 2021

Ideally this would be enabled in lieu of increasing the height of the CKE5 instance as soon as the length hits a certain threshold… but that doesn’t seem configurable yet according to https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/api/module_minimap_minimap-MinimapConfig.html.

I agree this would make sense in some itegrations. 

OTOH, since the minimap requires its own container (it consumes the horizontal space), this might be surprising or even troublesome for some integrators if it showed up on its own depending on the content of the edited document they have little-to-no control over. 

OTTH, this is pretty easy to implement on the integration side, all you need is to measure the height of the content (getBoundingClientRect() of the editing root) and show/hide the minimap container accordingly. There could be a dedicated editor plugin that manages this behavior. 

P.S.: long time no see, @oleq! 😊 👋

Nice to see you, too 😛

@108signals
Copy link

@oleq amazing work!

+1 for multiroot support

@projectitis
Copy link

Also just came here to say:
+1 for multiroot support :)

@privateOmega
Copy link

+1 for React Integration.

Thanks

@zgpnuaa
Copy link

zgpnuaa commented Sep 5, 2022

An error occurred after the webpack package was deployed on the production.
image

@someqq
Copy link

someqq commented Feb 10, 2023

催更

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@wimleers
Copy link

What?

Please don’t adopt this horrendously unempathetic autoclosebot policy 🤐👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

8 participants