Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watchdog#restart() should not be public #4701

Closed
Reinmar opened this issue Jul 8, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-watchdog#14
Closed

Watchdog#restart() should not be public #4701

Reinmar opened this issue Jul 8, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-watchdog#14
Assignees
@ma2ciek
Labels
package:watchdog type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 26

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 8, 2019

I don't see a use case for it. Even the docs mention that it's used internally.
@Mgsy
Copy link
Member

Mgsy commented Jul 16, 2019

cc @ma2ciek @pjasiun

@pjasiun
Copy link

pjasiun commented Jul 16, 2019

I agree we could remove Watchdog#restart() method.

@ma2ciek
Copy link
Contributor

ma2ciek commented Jul 22, 2019

I can agree with it. Also, if the restart() functionality will be somehow useful to anyone (e.g. in case of an error that he could detect), then he can do it manually by calling the Watchdog.destroy() and Watchdog#create() methods with the same effect.

Reinmar referenced this issue in ckeditor/ckeditor5-watchdog Jul 22, 2019
@Reinmar
Merge pull request #14 from ckeditor/t/13
69aef8b 
Other: Made the `Watchdog#restart()` method private. Changed the signatures of `Watchdog#create()` and `Watchdog#destroy()`, so now these methods will return empty promises. Closes #13.

BREAKING CHANGE: `Watchdog#restart()` is no longer public.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-watchdog Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added resolution:solved type:task This issue reports a chore (non-production change) and other types of "todos". package:watchdog labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:watchdog type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Make the Watchdog#restart() method private ckeditor/ckeditor5-watchdog
5 participants
@Reinmar @pjasiun @ma2ciek @mlewand @Mgsy