Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isDomNode to isNode #4993

Closed
ma2ciek opened this issue Feb 1, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-utils#220
Closed

Rename isDomNode to isNode #4993

ma2ciek opened this issue Feb 1, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-utils#220
Assignees
@ma2ciek
Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Feb 1, 2018

Utils inside the src/dom/ shouldn't have the DOM part in their names (like isRange(), isText()). See original dicussion: ckeditor/ckeditor5-utils#218 (comment).
@ma2ciek ma2ciek self-assigned this Feb 1, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-utils Feb 2, 2018
@Reinmar
Merge pull request #220 from ckeditor/t/219
1823196 
Other: Renamed `isDomNode()` to `isNode()`. Closes #219.

BREAKING CHANGE: `isDomNode()` was renamed to `isNode()`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:utils labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Rename isDomNode() to isNode() ckeditor/ckeditor5-utils
2 participants
@ma2ciek @mlewand