Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the dom/isText helper #4989

Closed
oleq opened this issue Dec 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#218
Closed

Implement the dom/isText helper #4989

oleq opened this issue Dec 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#218
Assignees
@ma2ciek
Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@oleq
Copy link
Member

oleq commented Dec 19, 2017

ATM we have isWindow(), isDomNode() and isRange(). The new helper should be used wherever possible (comment below) and work accross–iframes to avoid issues in the future.

A follow-up of ckeditor/ckeditor5-utils#213 (comment).
@oleq oleq changed the title Implement the isText helper Implement the dom/isText helper Dec 19, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-utils Feb 1, 2018
@Reinmar
Merge pull request #218 from ckeditor/t/214
a9a6bec 
Other: Introduced the `isText()` helper. Closes #214.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:utils labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Implement isText() helper ckeditor/ckeditor5-utils
3 participants
@oleq @ma2ciek @mlewand