Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for Blocktoolbar #5487

Closed
MCMicS opened this issue Oct 4, 2018 · 8 comments · Fixed by ckeditor/ckeditor5-ui#446
Closed

Translation for Blocktoolbar #5487

MCMicS opened this issue Oct 4, 2018 · 8 comments · Fixed by ckeditor/ckeditor5-ui#446

Comments

@MCMicS
Copy link

MCMicS commented Oct 4, 2018

I have set the language to German but the 'Edit Block' label will only be in English.
In Code I see no Translation for this.

see: https://github.com/ckeditor/ckeditor5-ui/blob/4a7f06fb1b6452b3c528a157a842e10a429f4517/src/toolbar/block/blocktoolbar.js#L214

@Reinmar
Copy link
Member

Reinmar commented Oct 5, 2018

The translations come from https://www.transifex.com/ckeditor/ckeditor5/ (feel free to join the project there). It might've been missing on the previous release, but I can see that German translation is complete now:

image

We plan a release next week, so you'll get all translations by then.

@Reinmar Reinmar closed this as completed Oct 5, 2018
@MCMicS
Copy link
Author

MCMicS commented Oct 5, 2018

But I found no *.po file with this message. I've tested latest build from npm

@Reinmar
Copy link
Member

Reinmar commented Oct 5, 2018

The latest build was published 2 months ago. The translation was completed on Transifex later, so it's not released yet.

@MCMicS
Copy link
Author

MCMicS commented Oct 5, 2018

So the *.po file will publishe then in code?
I've expected that the default en.po file exists in code

@Reinmar
Copy link
Member

Reinmar commented Oct 5, 2018

Doh... Good that you asked cause I was actually mistaken ;<<<

I checked that translations are completed but I didn't check whether we sent all translatable things to Transifex.

We're going to send this string today, if you'd join the German team on Transifex and fill it before Monday, we will release it next week.

Actually, you can also send me the translation for this string here and I'll fill it myself on Transifex.

@Reinmar Reinmar reopened this Oct 5, 2018
@MCMicS
Copy link
Author

MCMicS commented Oct 5, 2018

I've joined. My suggestions are:

en: Edit Block
de: Absatz bearbeiten

ma2ciek referenced this issue in ckeditor/ckeditor5-ui Oct 5, 2018
Fix: Made the `Edit block` string translatable. Closes #445.
@ma2ciek
Copy link
Contributor

ma2ciek commented Oct 5, 2018

Hi, @MCMicS.

Thanks for reporting this issue. I've fixed it and added your translation suggestion on the https://www.transifex.com/ckeditor/ckeditor5/translate/#de/ckeditor5-ui/154458859. It will be available in the next release, which we plan to do soon.

@MCMicS
Copy link
Author

MCMicS commented Oct 5, 2018 via email

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants