-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SplitButton's isOn=true
state is barely visible.
#3394
Comments
Adding: & > .ck-button,
& > * > .ck-button,
& > * > * > .ck-button { Fixes this but might be not the best solution: |
The problem has been analyzed correctly. That's more or less what we're supposed to do. But still that's a tricky one, I'm afraid. I've never liked this Christmas Tree selectors but I couldn't come up with a better one. Ideas: DecentralizationWe could move this logic to components/features – a drop-down would add such style and we could even provide a mixin for this (delivered by editorui). But then, these styles are not very useful, if someone decided to compile the theme without the Narrowing downInstead of & > .ck-button,
& > .ck-dropdown > .ck-button,
& > .something-to-do-with-split-button > .ck-button { There are not many of them. Would there be more (like much more)? I don't think so. It would also make more sense for developers decyphering this code because it clearly states what cases it covers. LGTM Another classA perfect solution would be a CSS class (e.g. |
So it should be like this: & > .ck-button,
& > .ck-dropdown > .ck-button,
& > .ck-dropdown > .ck-splitbutton > .ck-button { I'm fine with that as it is more clear what it does then Xmas tree before. |
Fix: Split button's arrow button should get a proper styling when the button is on. Closes #131.
The same goes for
actionView
:and
arrowView
:The text was updated successfully, but these errors were encountered: