This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #127 from ckeditor/t/113
Fix: Classic editor's editable should have a background. Closes #113.
- Loading branch information
Showing
4 changed files
with
63 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<style> | ||
body { | ||
background: red; | ||
} | ||
</style> | ||
|
||
<h2>Editor-classic</h2> | ||
|
||
<div id="editor-classic"> | ||
<p>This editable should have a background.</p> | ||
<p>This editable should have a background.</p> | ||
<p>This editable should have a background.</p> | ||
<p>This editable should have a background.</p> | ||
</div> | ||
|
||
<h2>Editor-balloon</h2> | ||
|
||
<div id="editor-balloon"> | ||
<p>This editable's background should be transparent.</p> | ||
<p>This editable's background should be transparent.</p> | ||
<p>This editable's background should be transparent.</p> | ||
<p>This editable's background should be transparent.</p> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/** | ||
* @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved. | ||
* For licensing, see LICENSE.md. | ||
*/ | ||
|
||
/* globals document, window, console */ | ||
|
||
import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor'; | ||
import BalloonEditor from '@ckeditor/ckeditor5-editor-balloon/src/ballooneditor'; | ||
import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset'; | ||
|
||
const config = { | ||
plugins: [ ArticlePluginSet ] | ||
}; | ||
|
||
ClassicEditor | ||
.create( document.querySelector( '#editor-classic' ), config ) | ||
.then( editor => { | ||
window.classicEditor = editor; | ||
} ) | ||
.catch( err => { | ||
console.error( err.stack ); | ||
} ); | ||
|
||
BalloonEditor | ||
.create( document.querySelector( '#editor-balloon' ), config ) | ||
.then( editor => { | ||
window.balloonEditor = editor; | ||
} ) | ||
.catch( err => { | ||
console.error( err.stack ); | ||
} ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
## Classic editor's editable should have a background [#113](https://github.com/ckeditor/ckeditor5-theme-lark/issues/113) | ||
|
||
1. The background of body should be red. | ||
2. The classic editor's editable background **should not** be red. | ||
2. The balloon editor's editable background **should** be red. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters