Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable media embeds in table cells #3257

Closed
oleq opened this issue Jan 14, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#162
Closed

Enable media embeds in table cells #3257

oleq opened this issue Jan 14, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#162
Assignees
@oleq
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 22

Comments

@oleq
Copy link
Member

oleq commented Jan 14, 2019

We can revert https://github.com/ckeditor/ckeditor5-table/issues/124 since images are allowed in tables and it seems there's no good reason to keep media banned from tables.

This will require https://github.com/ckeditor/ckeditor5-media-embed/issues/44.
@oleq oleq self-assigned this Jan 14, 2019
jodator referenced this issue in ckeditor/ckeditor5-table Jan 14, 2019
@jodator
Merge pull request #162 from ckeditor/t/161
9ace3ba 
Feature: Allowed media embeds in table cells. Closes #161.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 22
Development

Successfully merging a pull request may close this issue.

t/161: Allowed media embeds in table cells. ckeditor/ckeditor5-table
2 participants
@oleq @mlewand