Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check table post fixers/converters with text in table cell #3241

Closed
jodator opened this issue Oct 2, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#151
Closed

Check table post fixers/converters with text in table cell #3241

jodator opened this issue Oct 2, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#151
Assignees
@jodator
Labels
package:table status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 22

Comments

@jodator
Copy link
Contributor

jodator commented Oct 2, 2018

What if a cell already has some content, but that's a text?" problem
Follow up of:
ckeditor/ckeditor5-table#127 (review)

Check if converters work properly with #text inside table cells.
@jodator jodator self-assigned this Oct 2, 2018
@jodator
Copy link
Contributor Author

jodator commented Oct 2, 2018

ps.: AFAIR the $text is not allowed in the model of a table cell.

Reinmar referenced this issue in ckeditor/ckeditor5-table Feb 7, 2019
@Reinmar
Merge pull request #151 from ckeditor/t/134
5863307 
Fix: Autoparagraph text nodes in table cells. Closes #134.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:task This issue reports a chore (non-production change) and other types of "todos". package:table labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 22
2 participants
@jodator @mlewand