Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To-do list check marks fail WCAG #3024

Closed
oleq opened this issue Aug 19, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#242
Closed

To-do list check marks fail WCAG #3024

oleq opened this issue Aug 19, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#242
Assignees
@dkonopka
Labels
domain:accessibility This issue reports an accessibility problem. package:list type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 27 (v15...

Comments

@oleq
Copy link
Member

oleq commented Aug 19, 2019

image

https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=30D23F

Should be #1D8727 to pass AA for normal text.

image

cc @dkonopka
@dkonopka
Copy link
Contributor

Current background of checkbox hsl(120, 100%, 42%) has 1.97 contrast ratio
Your proposed color has 4.61 ratio.

But, it's a kind of graphical object so shouldn't we pass only 3.0 ratio? E.g: #26AB33

Screen Shot 2019-08-19 at 13 39 41

@oleq
Copy link
Member Author

oleq commented Aug 19, 2019

Alright. Let's settle this at 3:1.

@mlewand mlewand changed the title [A11y] To-do list check marks fail WCAG To-do list check marks fail WCAG Aug 27, 2019
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Sep 19, 2019
@oleq
Merge pull request #242 from ckeditor/t/ckeditor5-list/136
0d4a5e2 
Fix: To-do list styles should meet WCAG contrast standards and work with other editor features (e.g. font size). Closes ckeditor/ckeditor5-list#146. Closes ckeditor/ckeditor5-list#136.

Also moved some to-do list styles from ckeditor5-list (code refactoring).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-list Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added domain:accessibility This issue reports an accessibility problem. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:list labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
domain:accessibility This issue reports an accessibility problem. package:list type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

Introduced to-do list styles ckeditor/ckeditor5-theme-lark
3 participants
@oleq @mlewand @dkonopka