Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve styles of todo list #3019

Closed
oskarwrobel opened this issue Aug 13, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#242
Closed

Improve styles of todo list #3019

oskarwrobel opened this issue Aug 13, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#242
Assignees
@dkonopka
Labels
package:list type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 27 (v15...

Comments

@oskarwrobel
Copy link
Contributor

Follow-up: ckeditor/ckeditor5-list#133

We should check if todo lists (especially checkmark element) looks good with different font-family and font-size styles.
@oleq
Copy link
Member

oleq commented Aug 19, 2019

https://github.com/ckeditor/ckeditor5-list/blob/master/theme/list.css#L66

should be

border: solid hsl(0, 0%, 100%);

and the check should not have top but vertical-align: middle;

image

@elszczepano
Copy link
Member

elszczepano commented Aug 21, 2019 •
edited
Loading

Environment: Safari
Unchecked item has a white check on select

Screenshot 2019-08-21 at 11 45 52

oleq referenced this issue in ckeditor/ckeditor5-list Sep 19, 2019
@oleq
Merge pull request #153 from ckeditor/t/ckeditor5-list/136
43020ba 
Internal: Moved some to-do list styles to the ckeditor5-theme-lark repository. Code refactoring (see #136).
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Sep 19, 2019
@oleq
Merge pull request #242 from ckeditor/t/ckeditor5-list/136
0d4a5e2 
Fix: To-do list styles should meet WCAG contrast standards and work with other editor features (e.g. font size). Closes ckeditor/ckeditor5-list#146. Closes ckeditor/ckeditor5-list#136.

Also moved some to-do list styles from ckeditor5-list (code refactoring).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-list Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:list labels Oct 9, 2019
@dkonopka dkonopka mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
package:list type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

Introduced to-do list styles ckeditor/ckeditor5-theme-lark
5 participants
@oskarwrobel @oleq @mlewand @dkonopka @elszczepano