Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay off the technical debt the project got into during last major refactoring #94

Open
oleq opened this issue Jul 29, 2020 · 2 comments
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Jul 29, 2020

During the last refactoring (when the project moved to Redux, markers support was implemented, new selection rendering was implemented etc.) a technical debt has piled up. I only had limited time to finish the new features so I decided to ship the new inspector without some code that would normally be there:

  • there's no full test code coverage,
  • some essential tests are missing (related to the above),
  • there's a ton of code without documentation,

This debt is backfiring now when developing new features and fixing bugs. Mostly it's the missing coverage that causes problems because it is so easy to destabilize the application.

@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". squad:dx labels Jul 29, 2020
@jodator
Copy link
Contributor

jodator commented Jul 29, 2020

The Inspector is used by developers outside the CKEditor team so its stability might impact on how the whole project is perceived. Of course, this is a debug tool so other devs might understand minor bugs as long as the tool is usable.

My POV on this that the sooner we pay off some/most of the dept the better.

@jodator
Copy link
Contributor

jodator commented Aug 26, 2020

Related:

@jodator jodator modified the milestones: iteration 36, nice-to-have Aug 31, 2020
@Reinmar Reinmar removed the squad:dx label Sep 9, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants