This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Update logic for get 'img' form 'figure'. #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update logic for get
img
formfigure
view element.Fix strange behaviour with custom extending plugins with downcasting images attributes.
Issue describes here: ckeditor/ckeditor5#6294
Default behaviour for getting img-view element was :
.getChild( 0 )
it is not best when we have some tags before img 'tag'. It can be possible in future...Suggested behaviour:
Array.from( figureView.getChildren() ).find( viewChild => viewChild.is( 'img' ) );
and encapsulate it to utils function
getImgViewFromFigure()
.This approach provide ability to extend plugin logic with other custom plugins.