Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Image element should be cleared from progress if uploadId changed to null #201

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Image element should be cleared from progress if uploadId changed to null #201

merged 1 commit into from
Apr 4, 2018

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented Apr 4, 2018 •
edited by pomek
Loading

Fix: Image element will be cleared from upload progress classes if uploadId attribute changed to null. Closes ckeditor/ckeditor5#5145.

@scofalik scofalik requested a review from szymonkups April 4, 2018 12:36
@coveralls
Copy link

coveralls commented Apr 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e736849 on t/200 into 9f2dd28 on master.

@scofalik
Copy link
Contributor Author

scofalik commented Apr 4, 2018

I've rebased with master. Two tests fail, but they fail on master too.

@pjasiun pjasiun requested review from pjasiun and Mgsy and removed request for szymonkups April 4, 2018 14:39
@pjasiun pjasiun merged commit 5fadcf0 into master Apr 4, 2018
@pjasiun pjasiun deleted the t/200 branch April 4, 2018 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjasiun pjasiun pjasiun approved these changes

@Mgsy Mgsy Awaiting requested review from Mgsy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageUploadProgress: image element should be "cleaned" when it loses uploadId
3 participants
@scofalik @coveralls @pjasiun