This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Enable <img> inside <p> conversion #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r "bare image" conversion.
Docs: expanded autohoisting converters docs.
Reinmar
reviewed
May 3, 2017
| ); | ||
| } ); | ||
|
|
||
| it( 'multiple images', () => { |
There was a problem hiding this comment.
Uh... I looked for that test being afraid that you haven't thought about it :D 🥇
|
I have simplified bits of your PR. I'm a bit sad that it raises the complexity of the conversion in this feature even more but we have to live with this for a moment. At least, we'll have a lot of material to review when reviewing conversion after 1.0.0 alpha :D |
|
Make sure to read the commit message that I wrote. I focused on a bit different level – hopefully, more digestible for the readers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature:
<img>view elements placed inside<p>elements are now converted to a proper model structure both onsetData()and pasting (instead of being cleaned). Closes ckeditor/ckeditor5#5092.Additional information
This implements "autohoisting" idea, that is breaking ancestor(s) of an element if that element would be allowed in context without that ancestor(s). The idea is described in original issue ckeditor/ckeditor5#5092 and also here: https://github.com/ckeditor/ckeditor5-engine/issues/924
Because there were some conceptual problems with introducing generic autohoisting mechanism, I implemented autohoisting just for images for now.