Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizing side image using percents yields wrong size at first #5190

Closed
mlewand opened this issue Aug 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#308
Closed

Resizing side image using percents yields wrong size at first #5190

mlewand opened this issue Aug 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#308
Assignees
@mlewand
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 27 (v15...

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 19, 2019

Is this a bug report or feature request?

🐞 Bug report

💻 Version of CKEditor

CKEditor v5 @ latest master

📋 Steps to reproduce

  1. Open image resize manual test.
  2. Focus the image under "Image (width: not set)" section in the first editor.
  3. Turn it to a side image using image toolbar.
  4. Start to resize.

✅ Expected result

Image snaps precisely to the size pointed by the cursor.

❎ Actual result

Image has a much bigger size.

resizer-wrong-side-size
@mlewand mlewand assigned mlewand and unassigned mlewand Aug 19, 2019
Reinmar referenced this issue in ckeditor/ckeditor5-image Oct 3, 2019
@Reinmar
Merge pull request #308 from ckeditor/t/306
b084de5 
Fix: Initial resize of a side image with no width predefined now gives correct percentage values. Closes #306.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

Fixed resizer initial percentage values for sie images ckeditor/ckeditor5-image
1 participant
@mlewand