Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The InsertImage button shouldn't dictate where to insert images. #5163

Closed
jodator opened this issue Sep 20, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#228
Closed
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@jodator
Copy link
Contributor

jodator commented Sep 20, 2018

UI elements relays on Command to perform user actions like:

uiView.on( 'execute', () => {
	editor.execute( 'command' );
	editor.editing.view.focus();
} );

while the ImageButton also finds optimal insertion position.

IMHO the button should relay on this on ImageUploadCommand as it also depends on command's state.

I'd change this in #338.

// cc @pjasiun

@jodator jodator self-assigned this Sep 20, 2018
jodator referenced this issue in ckeditor/ckeditor5-image Sep 28, 2018
Other: The ImageUploadCommand should check whether it can be executed in the selection context. Closes #225. Closes #227. Closes #235.

BREAKING CHANGE: The `options.file` property was renamed to options.files for 'imageUpload' command.
BREAKING CHANGE: The `options.insertAt` property for 'imageUpload' command was removed. The command will now use model's selection.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
2 participants