Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add width attribute to responsive images #5120

Closed
szymonkups opened this issue Sep 29, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-image#146
Closed

Add width attribute to responsive images #5120

szymonkups opened this issue Sep 29, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-image#146
Assignees
@szymonkups
Labels
package:image type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 12

Comments

@szymonkups
Copy link
Contributor

After discussion here: https://github.com/ckeditor/ckeditor5-easy-image/issues/4. we decided that responsive images that have srcset attribute should have width attribute applied.
Current srcset attribute in model should be replaced by responsive attribute which will store information about srcset and width of the image. This way we will be sure that width converted to view is connected with image responsiveness and not just image attribute parsed separately.
@szymonkups szymonkups self-assigned this Sep 29, 2017
pjasiun referenced this issue in ckeditor/ckeditor5-image Sep 29, 2017
Merge pull request #146 from ckeditor/t/145
9ca651e 
Feature: Replaced srcset attribute in the model by responsive attribute which is now converted to three attributes in the view: srcset, sizes and width. Closes #145. Closes ckeditor/ckeditor5-easy-image#4.

BREAKING CHANGE: The srcset attribute is now replaced by responsive attribute in the model.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:image labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
@Witoso Witoso mentioned this issue May 15, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:image type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

Added "responsive" attribute to image element in model ckeditor/ckeditor5-image
2 participants
@szymonkups @mlewand