Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateCaptionVisibility throws when typing at the end of a link #5107

Closed
Reinmar opened this issue Jul 23, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-image#136
Closed

updateCaptionVisibility throws when typing at the end of a link #5107

Reinmar opened this issue Jul 23, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-image#136
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 12

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 23, 2017

jul-23-2017 22-58-13

I've got no idea why it throws but this happens in the situation I recorded. For some reason viewSelection.editableElement is undefined at that moment.
@scofalik scofalik self-assigned this Jul 24, 2017
@scofalik
Copy link
Contributor

scofalik commented Jul 24, 2017 •
edited
Loading

I've seen this problem already and I am working on it ATM. It is probably because view.Writer removes part of a text node in which view.Selection has been placed. If something is checked after view.Writer did it's work, but before view.Selection is refreshed, then you might got an error.

We should either handle view.Selection in view.Writer, or handle it on view nodes events, or do not use view.Selection#editableElement in "dangerous" places (during conversion, before rendering, etc.)

@scofalik scofalik removed their assignment Jul 24, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Sep 3, 2017

I'm encountering this pretty often, so let's give it a proper priority.

@szymonkups could you take a look on this?

@szymonkups szymonkups self-assigned this Sep 4, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-image Sep 6, 2017
@szymonkups
Added manual test for #127 issue.
a409034
scofalik referenced this issue in ckeditor/ckeditor5-image Sep 6, 2017
@scofalik
Merge pull request #136 from ckeditor/t/127
6147fee 
Fix: Fixed a bug causing editor with `ImageCaption` plugin enabled threw an error after view got rendered. Closes #127.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

Using model selection for calculating caption visibility ckeditor/ckeditor5-image
4 participants
@Reinmar @scofalik @szymonkups @mlewand