Double image toolbar when ContextualToolbar plugin is loaded

[oskarwrobel]

[oleq]

It's probably the same as https://github.com/ckeditor/ckeditor5-ui/issues/222#issuecomment-300104362, isn't it?

[oskarwrobel]

It is similar. Image can check if CT plugin is loaded and if it is, then uses beforeShow event to block CTof being displayed when the selection contains only image element.

[oleq]

Yes. At this stage it makes sense. But soon we'll struggle with these problems:

1. We may support some global commands when the image is selected, like the Link. How would users link such content if there's no toolbar? Keep in mind that tables will come with similar toolbar and the problem gets quite serious because you'd expect there's some way to bold table content, etc.
2. What if the image is the only item in the editable and the user wants to undo but there's no global toolbar?

So I guess we'd need to integrate this image toolbar with the contextual editor toolbar, i.e. the image–specific buttons will be displayed at the end of such toolbar.

[Reinmar]

What if the image is the only item in the editable and the user wants to undo but there's no global toolbar?

First of all, there are keystrokes. Second of all – the undo buttons should not be place in the contextual toolbar at all. It makes no sense. Contextual toolbar should be used for actions which are contextual.

We may support some global commands when the image is selected, like the Link. How would users link such content if there's no toolbar? Keep in mind that tables will come with similar toolbar and the problem gets quite serious because you'd expect there's some way to bold table content, etc.

The image toolbar needs to be correctly configured. It should feature the link button in such a case.