Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Size & Font Family UI/UX #2277

Closed
jodator opened this issue Nov 29, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-font#5
Closed

Font Size & Font Family UI/UX #2277

jodator opened this issue Nov 29, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-font#5
Labels
package:font status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@jodator
Copy link
Contributor

jodator commented Nov 29, 2017

To not duplicate lengthy talks from Highlight feature I'd like to ask you guys how the UI/UX for those features should like.

As a reminder both features will be uses as "non-semantic" features mostly in some conjuction with PasteFromWord (in the future) to individually style parts of text with different font size or font family.

Font sizes might be configured either as named presets or px values.


Previous thoughts on this:

We need to think how these two features (font family and font size) will be presented in the toolbar. The "Normal" label makes no sense for the dropdown's main button (imagine two "Normal" buttons next to each other ;)). So it seems that we need some icons for both of them. But then, do we also want to show the current size/family?

Also, in terms of UI, we may consider a single dropdown for both these features but I'd rather go with separate ones to not overcomplicate the initial implementation. Especially, if we'll choose to have just normal, small icons in those dropdown's main buttons.

Completely agree, remember that we have also heading, so it's equal to 3 dropdowns in a row, it's too much for the toolbar.

But then, do we also want to show the current size/family?

IMHO displaying enabled type like in headings it's not necessary.

We just need to properly present font-size and font-family icons.

@jodator
Copy link
Contributor Author

jodator commented Dec 15, 2017

As starters we go with buttons for both Font Family and Font Size.

The dropdown for font family will represent rendered font.

The dropdown for font size will represent configured values either as numbers ( for px values) either as texts (for named presets).

@oleq
Copy link
Member

oleq commented Dec 22, 2017

Added the icons in 2bc0718. To be continued in #645.

image

oleq referenced this issue in ckeditor/ckeditor5-font Feb 15, 2018
Feature: The initial font feature implementation. Closes #2. Closes #3. Closes #4.
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Feb 15, 2018
…onsistent look across the features (see ckeditor/ckeditor5-font#4).
oleq referenced this issue in ckeditor/ckeditor5-heading Feb 15, 2018
…ook across the features (see ckeditor/ckeditor5-font#4).
oleq referenced this issue in ckeditor/ckeditor5-ui Feb 15, 2018
…sure a consistent look of the component across the features (see ckeditor/ckeditor5-font#4).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-font Oct 8, 2019
@mlewand mlewand added status:discussion type:task This issue reports a chore (non-production change) and other types of "todos". package:font labels Oct 8, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:font status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants