-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IME][Safari] IME composition broken in empty paragraph in Safari #4533
Comments
Related PR: ckeditor/ckeditor5-engine#1783 |
Unfortunately, we have to revert the PR that fixed this issue: ckeditor/ckeditor5-engine#1783. After some deeper tests, it appeared that this fix is causing serious problems with track changes on Android (GBoard keyboard). As of now, the only way to reproduce the error is to use track changes plugin, which requires some additional set up: https://ckeditor.com/docs/ckeditor5/latest/features/collaboration/track-changes/track-changes.html. Basically, it is enough to turn on track changes and start typing at the beginning of a block (paragraph). The editor crashes after writing a few characters and a space. It is easier to crash if the paragraph has some bolded text in it. We will let you know if we have any further information about this issue. |
I've pushed branch Testing scenario:
As you can see, on typing This does not happen without the fix proposed in @farthinker's PR: Or when using a desktop browser. |
TODO: Verify whether #1333 is related to this issue. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
The original issue was described in #1333.
I've tried to fix it in https://github.com/ckeditor/ckeditor5-typing, but failed. Some IME cannot bear any DOM selection update.
So I thought maybe we should prevent DOM selection change while composing in the render process(like
return false
in_domSelectionNeedsUpdate
). I'll submit a PR later.The text was updated successfully, but these errors were encountered: