Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View post-fixers should be called only once just before "render" event #4433

Closed
jodator opened this issue Sep 28, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1569
Closed

View post-fixers should be called only once just before "render" event #4433

jodator opened this issue Sep 28, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1569
Assignees
@jodator
Labels
package:engine status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 20

Comments

@jodator
Copy link
Contributor

jodator commented Sep 28, 2018

Currently the post fixer are called on every view.change() call but I think that they should be called after all view changes - before rendering.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Oct 2, 2018
Merge pull request #1569 from ckeditor/t/1564
2f5af98 
Other: View post-fixer should be called once while rendering model changes. Closes #1564.

BREAKING CHANGE: View post-fixers are now called once while rendering model changes.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added module:view status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:engine status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 20
Development

Successfully merging a pull request may close this issue.

T/1564 ckeditor/ckeditor5-engine
2 participants
@jodator @mlewand