Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Writer to DowncastWriter #4404

Closed
f1ames opened this issue Aug 27, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1516
Closed

Rename Writer to DowncastWriter #4404

f1ames opened this issue Aug 27, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1516
Assignees
@f1ames
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 20

Comments

@f1ames
Copy link
Contributor

f1ames commented Aug 27, 2018

As we are going to introduce second View Writer called UpcastWriter (#1501), the former Writer needs to be renamed to keep things consistent. It will be renamed to DowncastWriter to play nicely with UpcastWriter.

Btw. isn't it a breaking API change?
@f1ames f1ames self-assigned this Aug 27, 2018
@pjasiun
Copy link

pjasiun commented Aug 27, 2018

Btw. isn't it a breaking API change?

The property will be still called writer, so I think this change will not touch many plugins, but it might be needed for some plugins to update.

So, since we already have some API changes in this iteration I believe we can add this one to the list of breaking changes.

@Reinmar
Copy link
Member

Reinmar commented Aug 27, 2018

Agree. It's a good moment to make this change.

scofalik referenced this issue in ckeditor/ckeditor5-engine Sep 4, 2018
@scofalik
Merge pull request #1516 from ckeditor/t/1515
5fd1ea5 
Other: Renamed view `Writer` to `DowncastWriter`. Closes #1515.

BREAKING CHANGE: The `engine/view/writer` module was renamed to `engine/view/downcastwriter`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f1ames f1ames

Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 20
Development

Successfully merging a pull request may close this issue.

Renamed view 'Writer' to 'DowncastWriter' ckeditor/ckeditor5-engine
4 participants
@Reinmar @f1ames @pjasiun @mlewand