Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce composition observer #4293

Closed
f1ames opened this issue Feb 28, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1330
Closed

Introduce composition observer #4293

f1ames opened this issue Feb 28, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1330
Assignees
@f1ames
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 14

Comments

@f1ames
Copy link
Contributor

f1ames commented Feb 28, 2018

While working on improving IME handling, there is a need to react on composition state changes. The composition observer should allow listening to composition events (compositionstart, compositionupdate, compositionstop) and also set proper document state marking that composition is taking place at the moment.
@f1ames f1ames self-assigned this Feb 28, 2018
@f1ames
Copy link
Contributor Author

f1ames commented Feb 28, 2018

It was already covered in ckeditor/ckeditor5-engine#861 so if possible code should be reused.

szymonkups referenced this issue in ckeditor/ckeditor5-engine Mar 5, 2018
@szymonkups
Merge pull request #1330 from ckeditor/t/1329
a0ad8fe 
Feature: Introduced composition observer. Closes #1329.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:view type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:engine labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f1ames f1ames

Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Introduced composition observer ckeditor/ckeditor5-engine
2 participants
@f1ames @mlewand