Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in the Differ broke block quote tests #4292

Closed
Reinmar opened this issue Feb 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1327
Closed

Change in the Differ broke block quote tests #4292

Reinmar opened this issue Feb 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1327
Assignees
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 26, 2018

https://travis-ci.org/ckeditor/ckeditor5/builds/345037426

Fails since ckeditor/ckeditor5-engine@e70ab96

With:

Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should wrap a single block FAILED
	AssertionError: expected '<p>abc</p><blockquote><p>x{}x</p><p>xx</p></blockquote><p>def</p>' to equal '<p>abc</p><blockquote><p>x{}x</p></blockquote><p>def</p>'
	    at Context.it (build/.automated-tests/entry-point.js:86501:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should wrap multiple blocks FAILED
	AssertionError: expected '<blockquote><h>a{bc</h><p>xx</p><p>de}f</p><h>abc</h><p>xx</p><p>def</p></blockquote>' to equal '<blockquote><h>a{bc</h><p>xx</p><p>de}f</p></blockquote>'
	    at Context.it (build/.automated-tests/entry-point.js:86524:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should merge with an existing quote FAILED
	AssertionError: expected '<blockquote><h>a{bc</h><h>abc</h><p>x}x</p><p>yy</p></blockquote><p>def</p>' to equal '<blockquote><h>a{bc</h><p>x}x</p><p>yy</p></blockquote><p>def</p>'
	    at Context.it (build/.automated-tests/entry-point.js:86548:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should not merge with a quote preceding the current block FAILED
	AssertionError: expected '<blockquote><p>abc</p></blockquote><blockquote><p>x{}x</p><p>xx</p></blockquote>' to equal '<blockquote><p>abc</p></blockquote><blockquote><p>x{}x</p></blockquote>'
	    at Context.it (build/.automated-tests/entry-point.js:86567:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should not merge with a quote following the current block FAILED
	AssertionError: expected '<blockquote><p>x{}x</p><p>xx</p></blockquote><blockquote><p>abc</p></blockquote>' to equal '<blockquote><p>x{}x</p></blockquote><blockquote><p>abc</p></blockquote>'
	    at Context.it (build/.automated-tests/entry-point.js:86587:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should merge with an existing quote (more blocks) FAILED
	AssertionError: expected '<blockquote><h>a{bc</h><p>def</p><h>abc</h><p>def</p><p>x}x</p></blockquote><p>ghi</p>' to equal '<blockquote><h>a{bc</h><p>def</p><p>x}x</p></blockquote><p>ghi</p>'
	    at Context.it (build/.automated-tests/entry-point.js:86613:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should not wrap non-block content FAILED
	AssertionError: expected '<blockquote><p>a{bc</p><p>abc</p></blockquote><widget>xx</widget><blockquote><p>de}f</p><p>def</p></blockquote>' to equal '<blockquote><p>a{bc</p></blockquote><widget>xx</widget><blockquote><p>de}f</p></blockquote>'
	    at Context.it (build/.automated-tests/entry-point.js:86638:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should correctly wrap and merge groups of blocks FAILED
	AssertionError: expected '<blockquote><p>a{bc</p><p>abc</p></blockquote><widget>xx</widget><blockquote><p>def</p><p>def</p><p>ghi</p></blockquote><widget>yy</widget><blockquote><p>jk}l</p><p>jkl</p></blockquote>' to equal '<blockquote><p>a{bc</p></blockquote><widget>xx</widget><blockquote><p>def</p><p>ghi</p></blockquote><widget>yy</widget><blockquote><p>jk}l</p></blockquote>'
	    at Context.it (build/.automated-tests/entry-point.js:86664:144)
Chrome 64.0.3282 (Linux 0.0.0) BlockQuoteCommand execute() applying quote should correctly merge a couple of subsequent quotes FAILED
	AssertionError: expected '<p>x</p><blockquote><p>a{bc</p><p>abc</p><p>def</p><p>ghi</p><p>jkl</p><p>mn}o</p></blockquote><p>y</p>' to equal '<p>x</p><blockquote><p>a{bc</p><p>def</p><p>ghi</p><p>jkl</p><p>mn}o</p></blockquote><p>y</p>'
	    at Context.it (build/.automated-tests/entry-point.js:86699:144)
Reinmar referenced this issue in ckeditor/ckeditor5-engine Feb 27, 2018
Fix: Improved how `model.Differ` checks whether the operation should be buffered or not. Closes #1326.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
3 participants