Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing registration of $marker element. #4288

Closed
oskarwrobel opened this issue Feb 21, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1319
Closed

Missing registration of $marker element. #4288

oskarwrobel opened this issue Feb 21, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1319
Assignees
@oskarwrobel
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@oskarwrobel
Copy link
Contributor

Markers are not converted from view to model because $marker element (temporary element that represents marker range in model) is not allowed by schema. Since marker conversion uses upcastElementToElement schema is checked and temporary element is skipped.
@oskarwrobel oskarwrobel self-assigned this Feb 21, 2018
@oskarwrobel
Copy link
Contributor Author

After #4171 this element won't be necessary but for now we need it.

pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 22, 2018
Merge pull request #1319 from ckeditor/t/1317
2d1d62f 
Fix: Registered $marker element in Schema. Closes #1317.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

T/1317 Registered $marker element in schema. ckeditor/ckeditor5-engine
2 participants
@oskarwrobel @mlewand