Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion utilities: move two-way converters as methods of Conversion class #4273

Closed
pjasiun opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Closed

Conversion utilities: move two-way converters as methods of Conversion class #4273

pjasiun opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Assignees
@scofalik
Labels
package:engine
Milestone
iteration 14

Comments

@pjasiun
Copy link

pjasiun commented Feb 9, 2018

It would be very useful in tests and simple features to writer:

editor.conversion.elementToElement( { model: 'paragraph', view: 'p' } );

No imports.

I think there is no point in exporting these functions as separate utils too, so the whole content of two-way-conveters should be moved to the Conversion class.
@pjasiun pjasiun changed the title Move two-way converters as methods of Conversion class Conversion utilities: move two-way converters as methods of Conversion class Feb 9, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 19, 2018
Merge pull request #1302 from ckeditor/t/1295
809ea24 
Other: Introduced several improvements to conversion helpers. Closes #1295. Closes #1293. Closes #1292. Closes #1291. Closes #1290. Closes #1305.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine
Projects
None yet
Milestone
iteration 14
3 participants
@pjasiun @scofalik @mlewand