Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model selection marker converter does not use descriptor#id #4170

Closed
scofalik opened this issue Aug 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1118
Closed

Model selection marker converter does not use descriptor#id #4170

scofalik opened this issue Aug 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1118
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@scofalik
Copy link
Contributor

Recently, we've changed how model to view markers conversion work. We introduced using HighlightDescriptor#id for highlights on text nodes. Unfortunately we forgot to do the same for model selection conversion.
@scofalik scofalik self-assigned this Aug 31, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-engine Sep 1, 2017
@szymonkups
Merge pull request #1118 from ckeditor/t/1117
e6c5bcf 
Fix: `AttributeElement`s created by selection conversion were not merged with `AttributeElement`s created by markers conversion. Closes #1117.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

convertSelectionMarker should use HighlightDescriptor#id ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand