Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection attributes are cleared from elements outside enqueue changes block #4133

Closed
scofalik opened this issue Jul 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1056
Closed

Selection attributes are cleared from elements outside enqueue changes block #4133

scofalik opened this issue Jul 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1056
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@scofalik
Copy link
Contributor

Original issue: https://github.com/ckeditor/ckeditor5-undo/issues/65#issuecomment-314216007

It appears that the fixer which clears selection attributes is applied outside of enqueue changes block, which messes up and crashes editor.
Reinmar referenced this issue in ckeditor/ckeditor5-engine Aug 22, 2017
@Reinmar
Merge pull request #1056 from ckeditor/t/1055
ed1b7e7 
Fixed: Selection attributes should be cleared in an `enqueueChanges()` block. Fixed also a bug concerning `AttributeDelta` x `SplitDelta` transformation. Closes #1055.
Reinmar referenced this issue in ckeditor/ckeditor5-undo Aug 22, 2017
@Reinmar
Merge pull request #70 from ckeditor/t/ckeditor5-engine/1055
2cfd595 
Tests: added integration test for ckeditor/ckeditor5-engine#1055.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

T/1055 Selection attributes should be cleared in an enqueueChanges block ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand