Merge pull request #1129 from ckeditor/t/1126

Fix: Spaces inside `<code>` will be rendered in a normal way (previously `DomConverter` tried to treat `<code>` like a preformatted block which is not what HTML requires). Closes #1126.
ckeditor · Sep 8, 2017 · 88630b7 · 88630b7
2 parents 3492420 + 9220a9d
commit 88630b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/view/domconverter.js b/src/view/domconverter.js
@@ -65,7 +65,7 @@ export default class DomConverter {
 		 *
 		 * @member {Array.<String>} module:engine/view/domconverter~DomConverter#preElements
 		 */
-		this.preElements = [ 'pre', 'code' ];
+		this.preElements = [ 'pre' ];
 
 		/**
 		 * Tag names of DOM `Element`s which are considered block elements.

diff --git a/tests/view/domconverter/view-to-dom.js b/tests/view/domconverter/view-to-dom.js
@@ -413,11 +413,11 @@ describe( 'DomConverter', () => {
 			} );
 
 			it( 'text node before in a preformatted node', () => {
-				const viewCode = new ViewAttributeElement( 'code', null, new ViewText( 'foo   ' ) );
+				const viewCode = new ViewAttributeElement( 'pre', null, new ViewText( 'foo   ' ) );
 				const viewDiv = new ViewContainerElement( 'div', null, [ viewCode, new ViewText( ' bar' ) ] );
 				const domDiv = converter.viewToDom( viewDiv, document );
 
-				expect( domDiv.innerHTML ).to.equal( '<code>foo   </code> bar' );
+				expect( domDiv.innerHTML ).to.equal( '<pre>foo   </pre> bar' );
 			} );
 		} );
 	} );