Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --expose-gc to Chrome's flags in Karma launcher configuration. #473

Merged
merged 2 commits into from
Jan 16, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Jan 15, 2019

Suggested merge commit message (convention)

Other: Add '--js-flags="--expose-gc"' flag to Karma Chrome launcher configuration. See ckeditor/ckeditor5#1341.


Additional information

@coveralls
Copy link

coveralls commented Jan 15, 2019

Coverage Status

Coverage remained the same at 89.147% when pulling 4eb57fd on t/ckeditor5/1341 into 4a2bbb9 on master.

@jodator
Copy link
Contributor Author

jodator commented Jan 16, 2019

@Reinmar & @pomek This PR shouldn't break anything so it would be nice to merge it and release a package for it so it will be available on Travis for mentioned PR in editor-core.

@pomek
Copy link
Member

pomek commented Jan 16, 2019

What about the CI? There is a second Chrome (CHROME_TRAVIS_CI) for CI only. Today you mentioned about the CI so maybe should we add it to both browsers?

@pomek pomek merged commit f2c0d05 into master Jan 16, 2019
@pomek pomek deleted the t/ckeditor5/1341 branch January 16, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants