Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleAttributeCommand is not calling refreshState() #2872

Closed
szymonkups opened this issue Dec 13, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-core#81
Closed

ToggleAttributeCommand is not calling refreshState() #2872

szymonkups opened this issue Dec 13, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-core#81
Assignees
@oleq
Labels
package:core type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@szymonkups
Copy link
Contributor

Now commands are not disabled even if schema forbids given attribute in current selection. For example when image is selected bold/italic buttons should be disabled:
output

It should probably listen to document changesDone event or selection change event and call refreshState then.
oleq referenced this issue in ckeditor/ckeditor5-core May 15, 2017
@oleq
Fix: ToggleAttributeCommand should correctly determine its initial st…
ec02edd 
…ate. Closes #50.
Reinmar referenced this issue in ckeditor/ckeditor5-core May 17, 2017
@Reinmar
Merge pull request #81 from ckeditor/t/50
6816505 
Fix: `ToggleAttributeCommand` should listen to reliable events in order to determine its state. Closes #50.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:core labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:core type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/50: ToggleAttributeCommand should correctly determine its initial state ckeditor/ckeditor5-core
3 participants
@oleq @szymonkups @mlewand