Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AttributeCommand #5542

Closed
Reinmar opened this issue Jun 18, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-basic-styles#48
Closed

Add AttributeCommand #5542

Reinmar opened this issue Jun 18, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-basic-styles#48
Assignees
@Reinmar
Labels
package:basic-styles type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 18, 2017

As discussed in https://github.com/ckeditor/ckeditor5-core/issues/14 – ToggleAttributeCommand could be moved here. Also, a name change would make sense.
@Reinmar Reinmar self-assigned this Jun 18, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Jun 19, 2017

I changed my mind – it doesn't make sense to call the command "base" sth if no other command extends this one. So it will be simply AttributeCommand.

@Reinmar Reinmar changed the title Add BaseAttributeCommand Add AttributeCommand Jun 19, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-basic-styles Jun 19, 2017
@szymonkups
Merge pull request #48 from ckeditor/t/47
0301d4a 
Feature: Introduced `AttributeCommand`. It was moved from `@ckeditor/ckeditor5-core/src/command/toggleattributecommand`. Closes #47.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-basic-styles Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:basic-styles labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:basic-styles type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/47: Added AttributeCommand (moved from the core) ckeditor/ckeditor5-basic-styles
2 participants
@Reinmar @mlewand