Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ckConfig interface #18

Closed
piernik opened this issue Jul 31, 2018 · 5 comments
Closed

Expose ckConfig interface #18

piernik opened this issue Jul 31, 2018 · 5 comments
Labels
pending:feedback This issue is blocked by necessary feedback. resolution:resolved This issue was already resolved (e.g. by another ticket).
Milestone

Comments

@piernik
Copy link

piernik commented Jul 31, 2018

We can provide ckconfig in config attribute.
Can You export it's complete interface in @ckeditor/ckeditor5-angular ?
It woulde be very nice to have full type support.

@pomek
Copy link
Member

pomek commented Jul 31, 2018

I guess the EditorConfig interface describes the configuration enough.

I can imagine that your idea has some sense but it will be hard to maintain. EditorConfig contains options for most of the CKEditor 5's plugins.

If we create a new plugin, it will force release this repository because the new plugin may introduce the new option in the interface.

@pomek pomek added the pending:feedback This issue is blocked by necessary feedback. label Jul 31, 2018
@piernik
Copy link
Author

piernik commented Aug 1, 2018

You're right. So maybe only present keys that has any as value?

@pomek
Copy link
Member

pomek commented Aug 1, 2018

cc: @ma2ciek

@ma2ciek
Copy link
Contributor

ma2ciek commented Aug 2, 2018

This is a complicated thing. As I've described in ckeditor/ckeditor5#504 (comment), each plugin should extend some base CKEditor5 interfaces and then our editor builds should concatenate these type declarations into one file, so they can be published with these declarations easily.

I've provided simple declarations in the https://github.com/ckeditor/ckeditor5-angular/blob/master/src/ckeditor/ckeditor.ts, but obviously, they're incomplete. You can look at https://github.com/ckeditor/ckeditor5-angular/blob/master/src/app/simple-usage/simple-usage.component.ts to see, how they're used. Those can be imported as import { CKEditor5 } from '@ckeditor/ckeditor5-angular/ckeditor'; I'll try to change the path in the future, so the import { CKEditor5 } from '@ckeditor/ckeditor5-angular'; will be also possible.

@ma2ciek
Copy link
Contributor

ma2ciek commented Aug 22, 2018

@ma2ciek ma2ciek closed this as completed Aug 22, 2018
@ma2ciek ma2ciek added this to the iteration 20 milestone Aug 31, 2018
@Reinmar Reinmar added resolution:resolved This issue was already resolved (e.g. by another ticket). and removed resolution:solved labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:feedback This issue is blocked by necessary feedback. resolution:resolved This issue was already resolved (e.g. by another ticket).
Projects
None yet
Development

No branches or pull requests

4 participants