-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ckConfig interface #18
Comments
I guess the EditorConfig interface describes the configuration enough. I can imagine that your idea has some sense but it will be hard to maintain. If we create a new plugin, it will force release this repository because the new plugin may introduce the new option in the interface. |
You're right. So maybe only present |
cc: @ma2ciek |
This is a complicated thing. As I've described in ckeditor/ckeditor5#504 (comment), each plugin should extend some base CKEditor5 interfaces and then our editor builds should concatenate these type declarations into one file, so they can be published with these declarations easily. I've provided simple declarations in the https://github.com/ckeditor/ckeditor5-angular/blob/master/src/ckeditor/ckeditor.ts, but obviously, they're incomplete. You can look at https://github.com/ckeditor/ckeditor5-angular/blob/master/src/app/simple-usage/simple-usage.component.ts to see, how they're used. Those can be imported as |
I'm closing it since it's already solved (https://github.com/ckeditor/ckeditor5-angular/blob/master/src/ckeditor/ckeditor.ts#L15). |
We can provide ckconfig in
config
attribute.Can You export it's complete interface in
@ckeditor/ckeditor5-angular
?It woulde be very nice to have full type support.
The text was updated successfully, but these errors were encountered: