From 3f95bf9c0714fcfc504214225b11365eba4dab4d Mon Sep 17 00:00:00 2001 From: Marek Lewandowski Date: Mon, 3 Sep 2018 17:08:59 +0200 Subject: [PATCH 01/13] Tests: added manual test. So far it's very dirty, but I when I tried few simplifications the content was gone. I'll probably simplify it in next commits. --- .../basicstyles/manual/htmlcomments.html | 12 +++++++++++ .../basicstyles/manual/htmlcomments.md | 20 +++++++++++++++++++ 2 files changed, 32 insertions(+) create mode 100644 tests/plugins/basicstyles/manual/htmlcomments.html create mode 100644 tests/plugins/basicstyles/manual/htmlcomments.md diff --git a/tests/plugins/basicstyles/manual/htmlcomments.html b/tests/plugins/basicstyles/manual/htmlcomments.html new file mode 100644 index 00000000000..fc775689055 --- /dev/null +++ b/tests/plugins/basicstyles/manual/htmlcomments.html @@ -0,0 +1,12 @@ + + + diff --git a/tests/plugins/basicstyles/manual/htmlcomments.md b/tests/plugins/basicstyles/manual/htmlcomments.md new file mode 100644 index 00000000000..9e28db80b12 --- /dev/null +++ b/tests/plugins/basicstyles/manual/htmlcomments.md @@ -0,0 +1,20 @@ +@bender-tags: bug, 2296, 4.10.1 +@bender-ui: collapsed +@bender-ckeditor-plugins: wysiwygarea, toolbar, basicstyles + +1. Open the console. +1. Focus the editor. +1. Select all the contents (`ctrl/cmd+a`). +1. Click "Bold" button in the toolbar. + +### Expected + +No error are thrown in the console. + +### Actual + +JS error is thrown, like `Uncaught TypeError: Cannot read property 'getParents' of null` + +### Notes + +[Edge will throw `Permission denied` exception](https://github.com/ckeditor/ckeditor-dev/issues/2035), this particular error is not related to this test. \ No newline at end of file From 47fd8fc696ac218b73600c9352108a56a3781580 Mon Sep 17 00:00:00 2001 From: Marek Lewandowski Date: Mon, 3 Sep 2018 17:22:10 +0200 Subject: [PATCH 02/13] Tests: slight simplification, more incoming. --- tests/plugins/basicstyles/manual/htmlcomments.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/plugins/basicstyles/manual/htmlcomments.html b/tests/plugins/basicstyles/manual/htmlcomments.html index fc775689055..a377ef0c32e 100644 --- a/tests/plugins/basicstyles/manual/htmlcomments.html +++ b/tests/plugins/basicstyles/manual/htmlcomments.html @@ -1,5 +1,5 @@