Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional styles preserved when copy/paste or drag/drop text from external source #986

Closed
f1ames opened this issue Sep 29, 2017 · 9 comments
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 29, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Go to https://sdk.ckeditor.com/samples/fullpreset.html.
  2. Copy/paste or drag/drop some text from outside of the editor to editor.

Expected result

Inserted text matches styles of the context.

Actual result

Inserted text preserves all its original styles.

image

I think the similar behaviour was the reason why pasteFilter: 'semantic-content' were introduced in Blink/Webkit browsers so maybe it can be reused here.

Other details

  • Browser: Edge 16+ (preview)
  • OS: Windows 10
  • CKEditor version: 4.7.3
  • Installed CKEditor plugins: clipboard
@f1ames f1ames added browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Sep 29, 2017
@f1ames
Copy link
Contributor Author

f1ames commented Sep 29, 2017

It will be a good idea to wait with this fix for #468.

@mlewand
Copy link
Contributor

mlewand commented Sep 29, 2017

Duplicate of #921.

@mlewand mlewand closed this as completed Sep 29, 2017
@mlewand mlewand added resolution:duplicate A duplicate of an already reported issue. and removed status:confirmed An issue confirmed by the development team. labels Sep 29, 2017
@f1ames
Copy link
Contributor Author

f1ames commented Sep 29, 2017

@mlewand Are you sure it is a duplicate of #921?

#921 is about incorrect transfer type recognition and this one is about preserving styles (btw. fixing transfer type recognition does not fix this issue).

@mlewand
Copy link
Contributor

mlewand commented Sep 29, 2017

@f1ames actually I might have done it too quickly. Above issue relates only to drag & drop, right?

However I wasn't able to reproduce it on https://sdk.ckeditor.com/samples/fullpreset.html with Microsoft EdgeHTML 15.15063, is it Edge 16 only thing?

@f1ames
Copy link
Contributor Author

f1ames commented Sep 29, 2017

@mlewand, no it is both copy/paste and drag/drop. You are right that it is only Edge 16 (updated Browser field to Edge 16+ so it is more visible).

@f1ames
Copy link
Contributor Author

f1ames commented Oct 3, 2017

@mlewand considering my latest comment, do you think we should reopen this issue?

@mlewand
Copy link
Contributor

mlewand commented Oct 3, 2017

K let's keep an eye on it as a separate issue.

@mlewand mlewand reopened this Oct 3, 2017
@mlewand mlewand added status:confirmed An issue confirmed by the development team. and removed resolution:duplicate A duplicate of an already reported issue. labels Oct 3, 2017
@f1ames
Copy link
Contributor Author

f1ames commented Nov 10, 2017

Looks like upstream https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/14591438/, but still may be good to consider a fix if Edge team will not be willing to do so.

@Dumluregn
Copy link
Contributor

This issue is no longer reproducible in the latest Edge browser version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants