Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save enabled only in design mode #817

Closed
jswiderski opened this issue Aug 22, 2017 · 0 comments
Closed

Save enabled only in design mode #817

jswiderski opened this issue Aug 22, 2017 · 0 comments
Assignees
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

https://dev.ckeditor.com/ticket/8354

Provide detailed reproduction steps (if any)

  1. Open editor and switch to source mode
  2. Try saving using editor toolbar button

Expected result

Saving with toolbar button should be possible in wysiwyg and source mode.

Actual result

Saving with toolbar button is only possible in wysiwyg mode.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 3.0
  • Installed CKEditor plugins: save

Initially this plugin was supposed to work in wysiwyg and source:
https://dev.ckeditor.com/ticket/2836#comment:14
https://dev.ckeditor.com/attachment/ticket/2836/2836_6.patch
but it has most likely been made to work in wysiwyg only by mistake:
https://dev.ckeditor.com/ticket/8354
https://dev.ckeditor.com/changeset/3285

Except for this "won't fix" ticket https://dev.ckeditor.com/ticket/10902, I haven't found any problems related to it.


Setting both modes to be dependent on form existence should fix this problem:
command.modes = { wysiwyg: !!( editor.element.$.form ), source: !!( editor.element.$.form ) };

@jswiderski jswiderski added status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. type:bug A bug. labels Aug 22, 2017
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Aug 23, 2017
@mlewand mlewand added this to the 4.7.3 milestone Aug 23, 2017
@wojtekw92 wojtekw92 self-assigned this Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants