Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First alteration of a text after pasting (ctrl+v) does not trigger 'change' event #554

Closed
dryzhkov opened this issue Jun 22, 2017 · 7 comments
Labels
plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. type:bug A bug.
Milestone

Comments

@dryzhkov
Copy link

dryzhkov commented Jun 22, 2017

Are you reporting a feature or a bug?

Bug

Check if the issue is already reported

http://dev.ckeditor.com/ticket/13763

EDIT: We have quite a few issue related to change event handling.
a. I believe 3 below are all duplicates or are very close to each other and one fix could handle all 3 of them
https://dev.ckeditor.com/ticket/13763
https://dev.ckeditor.com/ticket/14675
https://dev.ckeditor.com/ticket/13005
b. When implementing the solution, it would probably be best to create in a way that it allows fixing below issues in the future:
https://dev.ckeditor.com/ticket/13235
https://dev.ckeditor.com/ticket/14329
https://dev.ckeditor.com/ticket/14386
c. There is also a pull request which is panned to be reviewed for CKEditor 4.7.2 - #308

Provide detailed reproduction steps (if any)

  1. Paste text into the editor (ctrl +v).
  2. Select text.
  3. Press delete / backspace.

Expected result

Change event should be fired as the content of the editor is changed.

Actual result

Change event is not fired.

Other details

@msamsel msamsel self-assigned this Jun 29, 2017
@msamsel
Copy link
Contributor

msamsel commented Jun 29, 2017

Hi

I tested it on 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1. It worked fine on every version. I was able to attach my function on change event which was fired on Delete and Backspace pressing.
You can check my example under this link.
https://codepen.io/msamsel/pen/owpVBy?editors=1011

Browser: Chrome 59
OS: MacOs
Plugins: Full
CKEditor version: 4.6.0 - 4.7.1

Can you check if the problem occurs in your case?

@msamsel msamsel removed their assignment Jun 29, 2017
@dryzhkov
Copy link
Author

Can you try pasting text into the editor using ctrl-v in step #1? It appears if the text is typed in it works as expected but not when its pasted. Thanks

@f1ames
Copy link
Contributor

f1ames commented Jun 30, 2017

This is a known issue http://dev.ckeditor.com/ticket/13763 (First alteration to text after it is pasted in (ctrl+v) does not trigger 'change' event), but it happens only after paste, could you confirm that it is your case @dryzhkov?

@msamsel
Copy link
Contributor

msamsel commented Jun 30, 2017

I can confirm that. When text is pasting change event is missing. It's possible to achieve in my codepen mentioned before.

@msamsel msamsel added status:confirmed An issue confirmed by the development team. type:bug A bug. and removed status:pending labels Jun 30, 2017
@dryzhkov
Copy link
Author

Yep. Thats exactly what I am seeing. Looks like original bug was filed about 2 years ago.

@f1ames f1ames changed the title Change event is not fired when selected text is deleted First alteration of a text after pasting (ctrl+v) does not trigger 'change' event Jul 3, 2017
@f1ames
Copy link
Contributor

f1ames commented Jul 3, 2017

Thanks for confirming @dryzhkov. I altered issue title and description a little so it better describes the issue.

@f1ames f1ames added the plugin:clipboard The plugin which probably causes the issue. label Jul 3, 2017
@jswiderski jswiderski added the support An issue reported by a commercially licensed client. label Jul 12, 2017
@mlewand mlewand modified the milestones: Backlog, 4.8.0 Jul 14, 2017
@mlewand
Copy link
Contributor

mlewand commented Jul 20, 2017

@wojtekw92 please check what can be done about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:clipboard The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

6 participants