Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve encoding of custom emoji definitions #5128

Closed
jacekbogdanski opened this issue Mar 16, 2022 · 1 comment
Closed

Improve encoding of custom emoji definitions #5128

jacekbogdanski opened this issue Mar 16, 2022 · 1 comment
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.18.0

Comments

@jacekbogdanski
Copy link
Member

Type of report

Task

Provide description of the task

Emoji definitions can be passed by optional emoji_emojiListUrl config option. Currently, we are encoding these definitions using CKEDITOR.tools.htmlEncode function. It seems more reasonably to use CKEDITOR.htmlEncodeAttr function that should provide better encoding level.
@jacekbogdanski jacekbogdanski added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. labels Mar 16, 2022
@jacekbogdanski
Copy link
Member Author

Closed in 1bd802d0e84

@jacekbogdanski jacekbogdanski added this to the 4.18.0 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.18.0
Development

No branches or pull requests
1 participant
@jacekbogdanski