Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs builder does not use CKEDITOR_DEV_PATH environment variable #5019

Open
Comandeer opened this issue Jan 5, 2022 · 1 comment
Open

Docs builder does not use CKEDITOR_DEV_PATH environment variable #5019

Comandeer opened this issue Jan 5, 2022 · 1 comment
Labels
status:confirmed An issue confirmed by the development team. type:docs The issue is related to documentation type:task Any other issue (refactoring, typo fix, etc).

Comments

@Comandeer
Copy link
Member

Type of report

Task

Provide description of the task

Builder informs about using local CKE4 repo provided by CKEDITOR_DEV_PATH environment variable but actually it does not use it at all. The editor is always built using repos/ckeditor-presets submodule. We should fix the env var mechanism or remove it completely.
@Comandeer Comandeer added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. type:docs The issue is related to documentation size:? labels Jan 5, 2022
@Comandeer Comandeer mentioned this issue Jan 5, 2022
Merged
3 tasks
@Comandeer
Copy link
Member Author

It seems that this env variable is used when API docs are built. However, an editor used in all SDK examples is built using a repos/ckeditor-presets submodule. It means that API docs are created for a different version of the editor than the one presented to the end-users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:docs The issue is related to documentation type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Comandeer @jacekbogdanski