Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store templates in html files #4850

Closed
Fynn96 opened this issue Aug 18, 2021 · 1 comment · Fixed by #4851
Closed

Store templates in html files #4850

Fynn96 opened this issue Aug 18, 2021 · 1 comment · Fixed by #4851
Assignees
@Comandeer
Labels
plugin:templates The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.17.0

Comments

@Fynn96
Copy link
Contributor

Fynn96 commented Aug 18, 2021 •
edited
Loading

Type of report

Feature request

Provide description of the new feature

Currently the templates of the plugin Content Templates are stored as an concatenated String in the template file (like default.js). When there are many and, above all, long templates, the file gets really confusing. The HTML of the templates should be stored into seperated HTML files. The js file then should fetch the contents of the HTML file.
@Fynn96 Fynn96 added the type:feature A feature request. label Aug 18, 2021
@Comandeer Comandeer added plugin:templates The plugin which probably causes the issue. size:? status:confirmed An issue confirmed by the development team. labels Aug 18, 2021
@Fynn96 Fynn96 mentioned this issue Aug 18, 2021
Merged
3 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #4851

@CKEditorBot CKEditorBot added this to the 4.17.0 milestone Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
plugin:templates The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.17.0
Development

Successfully merging a pull request may close this issue.

Move template content to HTML files. Fynn96/ckeditor4
4 participants
@Comandeer @jacekbogdanski @CKEditorBot @Fynn96