Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fire Print on FF #4790

Closed
KarolDawidziuk opened this issue Jul 14, 2021 · 5 comments
Closed

Incorrect fire Print on FF #4790

KarolDawidziuk opened this issue Jul 14, 2021 · 5 comments
Assignees
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. plugin:preview The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@KarolDawidziuk
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

Open editor on FF and click on print button.

Expected result

Preview and print tab should open correctly. No error in the console.

Actual result

Preview are opened correctly but print preview is not available. No errors in the console.

Other details

This happens because FF trying fire print() method before page was fully loaded. We need wait for that.
In the preview plugin we can create some kind of public API to allow adding callback that fired when the preview window is loaded.

  • Browser:FF
  • OS: macOS, Windows
@KarolDawidziuk KarolDawidziuk added type:bug A bug. browser:firefox The issue can only be reproduced in the Firefox browser. status:blocked An issue which development is blocked by another issue (internal or external one). labels Jul 14, 2021
@KarolDawidziuk KarolDawidziuk added status:confirmed An issue confirmed by the development team. status:blocked An issue which development is blocked by another issue (internal or external one). and removed status:blocked An issue which development is blocked by another issue (internal or external one). labels Jul 19, 2021
@KarolDawidziuk KarolDawidziuk added this to the 4.16.2 milestone Jul 22, 2021
@KarolDawidziuk
Copy link
Contributor Author

Blocked by #4444.

@f1ames
Copy link
Contributor

f1ames commented Aug 4, 2021

As #4444 is done we can proceed with this one.

@f1ames f1ames added plugin:preview The plugin which probably causes the issue. size:? and removed status:blocked An issue which development is blocked by another issue (internal or external one). labels Aug 4, 2021
@f1ames
Copy link
Contributor

f1ames commented Aug 4, 2021

@KarolDawidziuk could you give more details on this one? Following the description (with CKEditor 4 4.16.1 and Firefox 90.0.2) it seems to be working fine. I see no content loss. Maybe some additional condition needs to be fulfilled? 🤔

Preview window:
image

Print window:
image

@KarolDawidziuk KarolDawidziuk self-assigned this Aug 5, 2021
@KarolDawidziuk
Copy link
Contributor Author

@f1ames It's strange because for me it's not working. There are no additional steps for reproducing it that were not mentioned in #4444. I tested it on macOS and Win7(vBox) and it fails. After #4758 fix preview works but print still not.

@f1ames
Copy link
Contributor

f1ames commented Aug 5, 2021

@KarolDawidziuk so if you mentioned #4444 it means it is CDN related too? It's not mentioned anywhere in this ticket or issue description so if that's the case it would be good to update repo steps / description here.

@jacekbogdanski jacekbogdanski added the release:blocker This issue blocks the upcoming release (is critical). label Aug 11, 2021
@jacekbogdanski jacekbogdanski removed the release:blocker This issue blocks the upcoming release (is critical). label Aug 11, 2021
@jacekbogdanski jacekbogdanski modified the milestones: 4.16.2, 4.16.3 Aug 12, 2021
@jacekbogdanski jacekbogdanski modified the milestones: 4.16.3, 4.17.0 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. plugin:preview The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants