Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CKEDITOR.tools.color should support new color syntaxes #4583

Closed
Comandeer opened this issue Mar 23, 2021 · 2 comments · Fixed by #4599
Closed

CKEDITOR.tools.color should support new color syntaxes #4583

Comandeer opened this issue Mar 23, 2021 · 2 comments · Fixed by #4599
Assignees
@Comandeer
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.17.0

Comments

@Comandeer
Copy link
Member

Type of report

Feature request

Provide description of the new feature

The newest version of CSS Colors specification defines new syntaxes for RGB and HSL colors – ones without commas as separators, e.g. rgb( 0 20 87 / 10%) is equivalent to rgb( 0, 20, 87, 0.1 ).

Additionally rgba and hsla functions are kept only for compatibility reasons as alpha channel is now supported directly in rgb and hsl functions. We do not support alpha channel in rgb and hsl.

There is also new syntax for hex colors – #RRGGBBAA. We do not support it.
@Comandeer Comandeer added type:feature A feature request. status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. size:M labels Mar 23, 2021
@f1ames
Copy link
Contributor

f1ames commented Mar 29, 2021

There is also new syntax for hex colors – #RRGGBBAA. We do not support it.

AFAIR it is supported already (as so called "8 digit hex" in the code). cc @sculpt0r

@f1ames f1ames added size:S and removed size:M labels Mar 29, 2021
@Comandeer Comandeer self-assigned this Mar 30, 2021
@Comandeer Comandeer mentioned this issue Mar 31, 2021
Merged
3 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #4599

@CKEditorBot CKEditorBot added this to the 4.17.0 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.17.0
Development

Successfully merging a pull request may close this issue.

Add support for new syntaxes in CKEDITOR.tools.color ckeditor/ckeditor4
3 participants
@f1ames @Comandeer @CKEditorBot