Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Style doesn't get applied correctly to styled header used together with form element #4141

Closed
jswiderski opened this issue Jul 6, 2020 · 1 comment
Assignees
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. plugin:font The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Setup CKEditor with below configuration:
var editor = CKEDITOR.replace( 'editor1', {
	extraAllowedContent : 'h4{*}'
});
  1. Switch to source mode and paste the following HTML
<div>
	<select>
	  <option>Other Languages</option>
	</select>
</div>
<div>
	<h4 style="font-family:arial,sans-serif;">Key Points</h4>
</div>
  1. Press Ctrl+A to select all content and change the font name to Comic Sans MS

Expected result

Text style in header gets changed to Comic Sans MS

Actual result

Text style in header doesn't get changed to Comic Sans MS.

To be more precise, with this particular HTML, whole div gets wrapped in span and you will only get select and h4 elements wrapped as expected if you switch to source mode and back or you get data from the editor using getData method.
obraz
obraz

Problem can be reproduced from CKEditor 4.0.0.

This doesn't happen when h4 has no font-family styling or when select tag is not present.

Other details

  • Browser: Firefox, IE11
  • OS: Any
  • CKEditor version: 4.0.0+
  • Installed CKEditor plugins: Font, Forms
@jswiderski jswiderski added type:bug A bug. browser:firefox The issue can only be reproduced in the Firefox browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. plugin:font The plugin which probably causes the issue. support:2 An issue reported by a commercially licensed client. labels Jul 6, 2020
@Dumluregn Dumluregn added the status:confirmed An issue confirmed by the development team. label Jul 7, 2020
@hub33k hub33k self-assigned this Aug 5, 2020
@hub33k hub33k removed their assignment Aug 12, 2020
@Comandeer Comandeer self-assigned this Aug 14, 2020
@f1ames
Copy link
Contributor

f1ames commented Aug 28, 2020

Fixed in d7a2fca.

@f1ames f1ames closed this as completed Aug 28, 2020
@f1ames f1ames added this to the 4.15.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. plugin:font The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

6 participants