The scrollIntoView() method uses non-existent "selection.type" property

[zentby]

ckeditor4/core/selection.js

Line 2495 in 8a12b04

if ( this.type != CKEDITOR.SELECTION_NONE )

this.type in the code above is always "undefined" as the type is not being maintained anywhere else. The correct reference call should be this.getType().

[f1ames]

Hello @zentby,

how did you find this issue, observed somewhere "in the wild"? This would mean that scrollIntoView() also executes when there is no selection in the editor probably throwing an error :thinking:

[zentby]

Hi @f1ames ,

I ran into this issue with my customized plugin that integrates with "autocomplete". The error is thrown within the execution of the next line, this.getRanges() is an empty list. The higher call stack is the "autocomplete"'s commit call. I marked a breakpoint here and observed the value is always undefined. The issue happens in Safari only.

[f1ames]

Thanks for the clarification @zentby 👍 Would yo be able to prepare a simple demo which reproduces this issue (e.g. on Codepen - you can start by forking this pen)?

[zentby]

Try this one
The issue could be observed in Safari (Mac) console. The editor didn't crash in the pen because I couldn't easily get a minimal example from my plugin.

If you set a breakpoint at LN:10574 as shown below, you'll be able to see that the this.type is always undefined.

Reproduce step:

1. Click the plugin button on the toolbar

[f1ames]

Thanks for the demo @zentby. There is something strange going on - from what I have checked our CKEDITOR.dom.selection class has only getType() method and no type property. The type property is available in native selection object. While scrollIntoView is CKEDITOR.dom.selection method it means it is using non-existent property 🤔 You can check what is logged here - https://codepen.io/f1ames/pen/wvKZGBW?editors=1010.

We will have to take a closer look into this one.

[jacekbogdanski]

Closed in #4127