Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printed content is different than the content in print preview #3661

Closed
f1ames opened this issue Nov 18, 2019 · 2 comments · Fixed by #3672
Closed

Printed content is different than the content in print preview #3661

f1ames opened this issue Nov 18, 2019 · 2 comments · Fixed by #3672
Assignees
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@f1ames
Copy link
Contributor

f1ames commented Nov 18, 2019

Type of report

Feature request

Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/docs/ckeditor4/latest/examples/fullpreset.html.
  2. Insert page break in the content.
  3. Click editors print button.

Expected result

Page break creates new page / page separation in printable document.

Actual result

Page break creates new page / page separation in printable document. Page break element is visible in the document on the preceding page.

image

Other details

  • Browser: Tested on Chrome.
  • OS: Linux
  • CKEditor version: 4.13.0 (4.10.0)
  • Installed CKEditor plugins: pagebreak,print
@f1ames f1ames added type:bug A bug. target:minor Any docs related issue that can be merged into a master or major branch. labels Nov 18, 2019
@msamsel msamsel added the status:confirmed An issue confirmed by the development team. label Nov 18, 2019
@Comandeer Comandeer self-assigned this Nov 18, 2019
@Comandeer
Copy link
Member

The issue is present for every other fake object inside the editor, e.g. anchor or iframe placeholder:

It's connected with the fact that our print plugin just invokes native print command:

if ( CKEDITOR.env.gecko ) {
editor.window.$.print();
} else {
editor.document.$.execCommand( 'Print' );
}

Therefore it's more of a feature request than bug.

OTOH it also means that for years our preview plugin has been totally useless…

@Comandeer
Copy link
Member

Probably the best course of action will be to join print and preview plugins. There will be still two buttons: preview one will just open the page with preview and print one – open the page and invoke printing it.

@Comandeer Comandeer changed the title Page break element is visible in print Printed content is different than the content in print preview Nov 18, 2019
@Comandeer Comandeer added type:feature A feature request. and removed target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug. labels Nov 18, 2019
@f1ames f1ames added this to the 4.14.0 milestone Nov 22, 2019
@f1ames f1ames modified the milestones: 4.14.0, Iteration 2019-1 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants